Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Separation of PUBLIC_URL into container-specific and client-specific URLs #1893

Open
1 task done
mnahinkhan opened this issue May 12, 2024 · 0 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version

Comments

@mnahinkhan
Copy link

Is there an existing issue for this feature?

  • Yes, I have searched the existing issues and it doesn't exist.

Feature Description

It seems to me that the PUBLIC_URL I provide in the docker compose config needs to be reachable from both the user's browser, as well the container running the server application. This probably works fine in cases where your PUBLIC_URL is open to public, but for my specific use case (and I suspect for many selfhosters) this is not the case, as we like to keep our home network inaccessible from the outside world.

For example, in my use case, I use Tailscale to access my homework remotely. I have set up my public DNS (something like "resume.MYDOMAIN.com" to point to my Tailscale address, which is accessible only when I'm connected to the Tailscale network.

As a result, their URL is accessible from my browser on any machine that is connected to my Tailscale network, but the container running chromium for example would not be able to reach the resolved IP (of resume.MYDOMAIN.com)

But yet the other containers are accessible using their docker network names ("app", "minio", etc) from the "chrome" container, so I was thinking it should be possible to separate these things (i.e. the client uses PUBLIC_URL to generate links to the resume etc but the server, specifically the chromium container, uses a different address like "http://app:3000" to connect to the app container).

The same arguments apply for the STORAGE_URL variable and "minio".

@mnahinkhan mnahinkhan added enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version labels May 12, 2024
@mnahinkhan mnahinkhan changed the title [Feature] Separation of PUBLIC_URL into container-specific and user-specific URLs [Feature] Separation of PUBLIC_URL into container-specific and client-specific URLs May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version
Projects
None yet
Development

No branches or pull requests

2 participants