Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug(?)]: Unity 2018, some timelines failed to export #1213

Open
Soneoylys opened this issue Feb 24, 2024 · 17 comments
Open

[Bug(?)]: Unity 2018, some timelines failed to export #1213

Soneoylys opened this issue Feb 24, 2024 · 17 comments
Labels
bug Something isn't working

Comments

@Soneoylys
Copy link

Are you on the latest version of AssetRipper?

Yes, I'm on the latest release of AssetRipper.

Which release are you using?

Windows x64

Which game did this occur on?

No response

Which Unity version did this occur on?

2018.4.7f1

Is the game Mono or IL2Cpp?

Mono

Describe the issue.

Some timeline failed to export with Unity 2018 (layout mismatched binary content (ArgumentOutOfRangeException)
This bug continues occurring during 0.2.x till now, on both Windows/macOS, other/older version untested.
I tried to omit this exception handler before, but the export still won't work.

If need any related files I can upload in here, but the complete game package is too big to upload.

Relevant log output

console output

@Soneoylys Soneoylys added the bug Something isn't working label Feb 24, 2024
Copy link

Thank you for submitting your first issue here. Please be sure you have uploaded your AssetRipper.log file. It is in the same folder as the exe file. :)

@Soneoylys
Copy link
Author

Maybe is same issue as #698
If needed, I can try to trim down the game and upload here.

@ds5678
Copy link
Collaborator

ds5678 commented Feb 25, 2024

If those classes use [SerializeReference] attributes, this is indeed a duplicate of #698.

@Soneoylys
Copy link
Author

If those classes use [SerializeReference] attributes, this is indeed a duplicate of #698.

Anywhere I can confirm that?
Is that somewhere in recovered game project

@ds5678
Copy link
Collaborator

ds5678 commented Feb 25, 2024

Load the appropriate dll assembly into ILSpy.

@Soneoylys
Copy link
Author

Load the appropriate dll assembly into ILSpy.

Thanks, I searched in the csharp script, but seems there's no class using [SerializeReference]

@ds5678
Copy link
Collaborator

ds5678 commented Feb 26, 2024

Load the appropriate dll assembly into ILSpy.

Thanks, I searched in the csharp script, but seems there's no class using [SerializeReference]

Some Unity assemblies (correctly) do not get decompiled by AssetRipper, so searching the AssetRipper output is insufficient.

@Soneoylys
Copy link
Author

Soneoylys commented Feb 26, 2024

Load the appropriate dll assembly into ILSpy.

Thanks, I searched in the csharp script, but seems there's no class using [SerializeReference]

Some Unity assemblies (correctly) do not get decompiled by AssetRipper, so searching the AssetRipper output is insufficient.

I did searched with exported script by ILSpy instead of AssetRipper result, still no luck
Or maybe I can upload trimmed game files (will be around 2GiB, or managed dlls only) here?

@ds5678
Copy link
Collaborator

ds5678 commented Feb 26, 2024

From what I can see, the issue is probably with PropertyName exposedName.

namespace Timeline
{
	public class TimeControlAsset : PlayableAsset, ITimelineClipAsset, IPropertyPreview
	{
		public ExposedReference<TimeControlBaseObject> Target;

		//Other content
	}
}

https://github.com/Unity-Technologies/UnityCsReference/blob/79868d37d65d6efb5196aaf002f97a6f87b22f97/Runtime/Export/Director/PlayableAsset.cs

https://github.com/Unity-Technologies/UnityCsReference/blob/79868d37d65d6efb5196aaf002f97a6f87b22f97/Runtime/Export/Director/ExposedReference.cs#L16-L20

@ds5678
Copy link
Collaborator

ds5678 commented Feb 26, 2024

Seems like #511

@Soneoylys
Copy link
Author

Soneoylys commented Feb 26, 2024

From what I can see, the issue is probably with PropertyName exposedName.

Thanks for reply, I'll go check if it is this case or not

@Soneoylys

This comment was marked as off-topic.

@ds5678
Copy link
Collaborator

ds5678 commented Feb 26, 2024

PNG files are completely unrelated to this issue. If there's a problem with them, post a new issue.

@Soneoylys
Copy link
Author

PNG files are completely unrelated to this issue. If there's a problem with them, post a new issue.

Thanks, I filed a new issue as #1214

@Soneoylys
Copy link
Author

From what I can see, the issue is probably with PropertyName exposedName.

Thanks for reply, I'll go check if it is this case or not

Yes, the game script utilized PropertyName exposedName for timelines.

@Soneoylys
Copy link
Author

I'm kindly asking if any progress on this issue, I tried to backflash to #511 and seems the issue closed at commit "0d45e9de6aff91fcbf20ad67862e1555a9008329", but due to this part has been reflect for a few times like #227, so
it's sort of hard for me to debugging back those scripts to try resolve by myself.

@ds5678
Copy link
Collaborator

ds5678 commented Mar 15, 2024

I haven't looked at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants