-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Shader Decompilation fails on Slime Rancher 2 #726
Comments
This is an issue with shader decompilation.
|
Shader decompilation is experimental and bugs are to be expected. Most of the contributors, including myself, have higher priorities at the moment, so this might not be investigated for a long time. If you're able, I encourage you to investigate the issue and contribute a pull request with improvements. |
I dont know if u found a fix. That error occurs when the shadersubprogram dosent have bindings. I did a dirty fix for this. If u dont understand, well not that I ever expect anything Iv written to make sence. ill update a fork of this project with changes. If u still have issues let me know with error log Im happy to help...
Here is the function used above...
Then passed the data to function below
|
Also note that above resource files are from a different game but the error I faced is same. |
Here you can follow the changes to code. Forgot to mention it's reading only buffers from common property. |
@RealCA I don't feel like editing stuff rn, I can wait for sometime lol. |
I will be upload a release. If u like u could test |
U will need to install net 7 😜 |
Can this be made into a PR, reviewed, tested and merged into master? |
If someone makes a PR, I'll review it (and possibly merge it). |
Note: If anyone sets out to do this, you will need to coauthor any commit that contains code from @RealCA, which requires their noreply anonymous email address from GitHub. 0a8376b |
Will you open a pr for this? |
Are you on the latest version of AssetRipper?
Yes, I'm on the latest release of AssetRipper.
edit: I forgot to update, I did, I still have the error
Which release are you using?
Windows x64
Which game did this occur on?
[Slime Rancher 2] (https://steamdb.info/app/1657630/)
Which Unity version did this occur on?
2021.2.10
Is the game Mono or IL2Cpp?
IL2Cpp
Describe the issue.
During export error messages started coming up in log, and the export stopped
Relevant log output
log too long to send: https://drive.google.com/file/d/1wzCkMdcMdT-WdfdKfBVpx2wPmyE2HNnH/view?usp=share_link
The text was updated successfully, but these errors were encountered: