-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: convert markdown issue templates to issue forms #1238
Conversation
Co-authored-by: Vuillemot Florian <vuillemot.florian@outlook.fr>
@florian-vuillemot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly minor typographical change requests for better homogeneity.
Great work!
d29e9f3
@FabienLelaquais |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Anmol-Baranwal for your help.
Hi Team, if everything is okay, please review and merge this PR. |
The two other reviewers are currently on vacation. They should be back in a couple of days. I am waiting for a second approval, and once it's ok, I'll merge it. Thank you again. |
Hi Team! One of the tests failed due to a spelling error in Let me know your decision. I'm unsure about the issue with the other one. Have a great day! |
Hello, Oh, right. If you can fix it, that would be great. Thank you. |
@jrobinAV Anyway, I have updated it with the documentation label present in the repo. I hope this works!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thanks!!
closes #1234
Changes proposed
I've added five issue forms in total and removed existing markdown templates.
I've used the existing templates as inspiration (especially the acceptance criteria).
You can see how these will preview on my fork branch. You cannot see it while creating an issue (which I've enabled) because it's in another branch and not in the
main
branch.If you want to see how the final issue forms will look in general, then you can check this or this. I've contributed it myself a few months back.
Why Issue forms
Note to reviewers
*
Asterisk.I've also added a bit of Markdown content to improve context.
I've used labels of existing templates except for
discussion
anddocumentation
. Let me know if any changes are necessary in that.@jrobinAV
Please suggest any necessary changes, and I will make them!