Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change damage type to MELTING #25

Open
TheWranger opened this issue Jan 12, 2019 · 4 comments
Open

Change damage type to MELTING #25

TheWranger opened this issue Jan 12, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TheWranger
Copy link

Is your feature request related to a problem? Please describe.
It can be hard to set up death messages specifically for acid if we have other plugins killing players and using the CUSTOM damage type.

Describe the solution you'd like
I suggest that this be changed to MELTING so that it can be easier to specifically set up death messages for acid and acid rain without getting in the way of other plugins.

Describe alternatives you've considered
Option in the config to change the damage type

Additional context
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/event/entity/EntityDamageEvent.java#280

@tastybento
Copy link
Member

Sounds like a good idea. By the way, how do you set up the messages? Is that another plugin?

@TheWranger
Copy link
Author

Different plugin, DeathMessagesPrime is a commonly used one and is considered to be the best;
https://www.spigotmc.org/resources/deathmessagesprime.3789/

@tastybento tastybento added enhancement New feature or request help wanted Extra attention is needed labels Jan 19, 2019
@tastybento
Copy link
Member

I did some investigation and I do not see a way to do this with the Bukkit API. If anyone else knows how to set custom DamageCause to player damage, let me know!

@tastybento
Copy link
Member

There is a PR to Spigot open to enable this, but it's not accepted yet. https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/469/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants