Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bbox reload #2200

Open
tastybento opened this issue Oct 13, 2023 · 2 comments
Open

Fix bbox reload #2200

tastybento opened this issue Oct 13, 2023 · 2 comments
Assignees
@tastybento
Labels
Status: Under investigation Investigating the interest and the feasability of the issue.

Comments

@tastybento
Copy link
Member

tastybento commented Oct 13, 2023 •
edited

Expected behavior

Reload will reload what it can for addons.

Observed/Actual behavior

Reload doesn't reload addons

Steps/models to reproduce

bbox reload

BentoBox version

Latest

Plugin list

No response

Other

No response
@tastybento
Copy link
Member Author

@BONNe I looked at the code and right now it doesn't reload the addons; it just reloads the lcoales and placeholders. Was this already fixed then?

@BONNe
Copy link
Member

BONNe commented Oct 16, 2023

It looks like. But I think currently the issue is that it does not trigger Addon#onReload
I think it should be triggered.

@tastybento tastybento self-assigned this Oct 17, 2023
@tastybento tastybento changed the title Remove reload Fix bbox reload Oct 17, 2023
@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Under investigation Investigating the interest and the feasability of the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BONNe @tastybento