New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bentobox massive lag spike during island removal due to IA custom blocks that do not exist #2297
Comments
Use |
Yes, the issue is that when the island is being deleted, the code tells ItemsAdder that the block is being removed, for each block. We had the same problem with SlimeFun, but I was able to fix it because their API has a way to check for blocks. I think I'll temporarily remove the hook so that there isn't lag at the expense of not deleting IA blocks. |
The other option is to drastically reduce the number of blocks deleted in one go in the BentoBox config.yml. Anyway, I'll try and see if this can be optimized. You can use the snapshot 2.0.1 version. |
Thanks! |
Mostly just custom blocks |
Try the very latest build on the CI server. I added NMS support for older versions - before, it would only optimize for 1.20.4, so if you were using 1.20.2, then it would be using the Bukkit API to copy and paste blocks. |
I asked the dev for some API addition to prevent the lag, but let's see. PluginBugs/Issues-ItemsAdder#3445 |
Great! Anyway don't know what's going on, I just updated Bentobox to the latest build and addons too, but there's lag when I invite a player. Looks like I have to stick with no island removal for now. |
Having same issue with purging unowned islands, because I just disabled automatic island removal. It's not really that massive, but probably same lag spike. So currently I have no way how to avoid this lag. Any idea @tastybento ? I've got lag when I purged just 4 islands. |
I need logs or stats to see where the lag is coming from when you do this. It may be some other location. Can you post a Spark report? |
Here it is, I think it's very similar when I am purging islands. |
Hmm forgive me but that seems all okay - 20 tps across the board. Although BentoBox does use CPU, the TPS are not affected (at least according to that report). It looks like the staggering system is working. What do you actually experience in game? |
Okay thanks. Let's see what we can tweak. |
Same problem with 1.20.4, but looks like for example obadmin purge unowned doesn't lag like that, it only takes not even 1 tps. Problem is reset itself. |
Expected behavior
It shouldn't lag like this. Version 1.24.1 didn't have this problem.
Observed/Actual behavior
When you invite someone and the chosen player already has his island, massive lag will start due to Itemsadder custom blocks (which are not even here). I'm not even use any custom blocks, there's literally that one AOneblock block.
Steps/models to reproduce
BentoBox version
2.0.1-SNAPSHOT-b2557 with generated addons
Plugin list
Plugins (14): AnimatedScoreboard, BentoBox, Bentobox-AOneBlock, BentoBox-Biomes, BentoBox-Level, BentoBox-Visit, BentoBox-Warps, ItemsAdder, LoneLibs, LuckPerms, ProtocolLib, Vault, ViaBackwards, ViaVersion
Other
Using fork of paper Pufferfish 1.20.2, ItemsAdder 3.6.3-beta-5 and LoneLibs 1.0.43.
The text was updated successfully, but these errors were encountered: