Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how /is purge works to be team based. #2359

Closed
2 tasks done
spookymgmt opened this issue May 9, 2024 · 2 comments · Fixed by #2362
Closed
2 tasks done

Update how /is purge works to be team based. #2359

spookymgmt opened this issue May 9, 2024 · 2 comments · Fixed by #2362
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@spookymgmt
Copy link

Is your feature request related to a problem?

The /is purge command in redundant when using it in a multiplayer experience.

Currently, the command is ran on every server reboot, but according to support in the discord, it completely skips any islands that are part of a team.

How does that help me?

Describe the solution you'd like.

I think this feature should be changed, so that it works like this:

When /is purge 10 is ran for example, it will check every island on the server, and in order for an island to be purged, the following requirement must be met.

  • EVERY SINGLE MEMBER OF THE ISLAND MUST BE OFFLINE FOR > 10 DAYS.

This would make for a very good purge system, compared to what we have now.

That way, it's not skipping islands with a team, and, if it was still only owner based, what if owner invites friend, owner quits playing server, but friend keeps playing. You do not want to purge the island on him. So it just makes the most sense to do a check, and see if EVERY SINGLE team member has been offline for the purge arg time.

Describe alternatives you've considered.

Asked in discord.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

$20 bounty

@tastybento tastybento self-assigned this May 11, 2024
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. labels May 11, 2024
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. labels May 11, 2024
@tastybento
Copy link
Member

@spookymgmt This is done. Please have a check and confirm it works how you expect.

@spookymgmt
Copy link
Author

Putting it live now, don't really have a great way to test it I don't think, but maybe I can setup a test server this Monday and see. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants