Dumb objectiveconfiguration (loop) can overload server - Warning would be useful

[bundabrg]

Reported by Toffy in Discord:

I found an easy way to crash a server.

• Make an objective that on finish, will run 2 events, one, removing a certain journal entry, and another one "objective finish objectivename" , the objectivename will be the objective finishing itself.

• Since the objective finishing, runs another event finishing itself, it will finish itself over and over, keep running the journal entry update over and over, eventually overusing server resources.

I haven't tested with other events, only journal entry updates

[J0B10]

I guess you can also do this with the folder event:

Create a folder event without a delay that executes itself and another event.
In fact every recursive call of events without a delay will at some point lead into a heap space or a stack overflow exception and crash the server.

I don't see a big issue here cause it is quite obvious that that shouldn't be done and it isn't your job to prevent every eventuality where the plugin could be misused.

Nevertheless if you could write a simple fix it would improve usability.
But atm I see no simple way of detecting these kind of recursive calls.
Maybe the wiki should be updated to make all quest writers aware of this issue.

[TofPlays]

I didn't report it as a bug, just noted it, However I'm all for improving usability. And yeah it is user's responsibility to use those things wisely.

[bundabrg]

I logged it mainly just to look closer later. Infinite loops don't necessarily need protection from but as it is easy to get into this scenario with how BQ has assets across multiple files either a timeout or a check during loading the info might be implemented.

[Wolf2323]

This could help detecting loops, if we want to fix it https://stackoverflow.com/a/2663147/10134392