Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position bug of the player with a mount #2119

Open
2 tasks done
Weyl1 opened this issue Nov 9, 2022 · 2 comments
Open
2 tasks done

Position bug of the player with a mount #2119

Weyl1 opened this issue Nov 9, 2022 · 2 comments
Labels
Bug A bug in the code or in a documentation. Confirmed Something is confimed.

Comments

@Weyl1
Copy link

Weyl1 commented Nov 9, 2022

Confirm the following

  • I use the latest release or dev-build. I also checked that this problem hasn't already been fixed in a newer dev-build.
  • There are no open or closed issues that are related to my problem.

BetonQuest version information

BetonQuests DEV 2.0.0-DEV-442
Server PurPur-1825 1.19.2

Expected behaviour

If a player uses a mount, it is not removed and can be used to take a quest or removed to avoid bugs.

Actual behaviour

When a player takes a quest with a mount (horse for example) this one makes bug the position of the player and the mount thinks we are still on it

Steps to reproduce

https://www.youtube.com/watch?v=WluCPKhGmAc

Error, Warning, Exception or Thread Dump

No response

Additional information

https://www.youtube.com/watch?v=WluCPKhGmAc

@Weyl1 Weyl1 added the Bug A bug in the code or in a documentation. label Nov 9, 2022
@Wolf2323 Wolf2323 added the Confirmed Something is confimed. label Nov 9, 2022
@Wolf2323
Copy link
Member

Wolf2323 commented Nov 9, 2022

Ok i can confirm the issue. If a player is mounted on an entity, and the player enters a Conversation, the player is mounted on the armorstand, but only client side. If the player press shift, he is dismounted, but also only client side. So for the server he is still on the entity mounted.

Possible solutions:

  1. Disallow conversations while mounted on an entity
  2. Dismount the player from the entity (maybe the entity can then be stolen)
  3. Let the player mounted

For solution 3 we need to adjust the position for the armorstand while the player is still on the entity riding it, so the height makes more sense. After the conversation, we need to remount the player on the original entity. (problem, may the entity continue traveling in a direction, this is may a bigger issue for conversations with stop true)

@Weyl1
Copy link
Author

Weyl1 commented Nov 9, 2022

Or why not add a feature that would allow to check if the player is already on a mount, and directly freeze the mount in question during the dialogue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the code or in a documentation. Confirmed Something is confimed.
Projects
Status: Todo
Development

No branches or pull requests

2 participants