Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the hiding of Player and Entities #2512

Open
2 tasks done
Wolf2323 opened this issue Sep 14, 2023 · 0 comments
Open
2 tasks done

Issues with the hiding of Player and Entities #2512

Wolf2323 opened this issue Sep 14, 2023 · 0 comments
Labels
Bug A bug in the code or in a documentation.

Comments

@Wolf2323
Copy link
Member

Confirm the following

  • I use the latest release or dev-build. I also checked that this problem hasn't already been fixed in a newer dev-build.
  • There are no open or closed issues that are related to my problem.

BetonQuest version information

BetonQuest version: 2.0.0-DEV-702
Server version: git-Paper-111 (MC: 1.20.1)

Hooked into: Citizens (2.0.32-SNAPSHOT (build 3198)), DecentHolograms (2.8.3), ProtocolLib (5.1.0), WorldEdit (7.3.0-SNAPSHOT+6498-ff8e505)

Expected behaviour

Hiding of Players and Entities should be handled consistent and correctly. With maybe some configurable options

Actual behaviour

The current hiding has two main issues:

PlayerHider
Uses the hidePlayer method from bukkit
Also hides players from the tab list and from tab completion what is not always expected.

EntityHilder
Uses ProtocolLib package hiding
Only hides entities package based what keeps the hitboxes some particles and sounds, and also does not hide things like shot arrows

Steps to reproduce

Use the PlayerHider nad watch the Tab list or try to tab complete the player

Use the NPCHider/MythicMob(private mods) feature and shoot them with an arrow while they are hidden

Error, Warning, Exception or Thread Dump

none

Additional information

This is more like a rework then an actual bug/issue, but it could cause issues

@Wolf2323 Wolf2323 added the Bug A bug in the code or in a documentation. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the code or in a documentation.
Projects
Status: Todo
Development

No branches or pull requests

1 participant