Async condition task handling

[Condordito]

Confirm the following

• I use the latest release or dev-build. I also checked that this problem hasn't already been fixed in a newer dev-build.
• There are no open or closed issues that are related to my problem.

BetonQuest version information

BetonQuest version: 2.1.2-DEV-4
Server version: git-Paper-462 (MC: 1.20.4)

Hooked into: Citizens (2.0.33-SNAPSHOT (build 3365)), EffectLib (10.2), MMOCore (1.12.1-SNAPSHOT), MMOItems (6.10-SNAPSHOT), MythicLib (1.6.2-SNAPSHOT), MythicMobs (5.6.2-SNAPSHOT-7679d6a3), PlaceholderAPI (2.11.5), ProtocolLib (5.2.0-SNAPSHOT-679), Vault (1.7.3-CMI)

Expected behaviour

Conversations should run asynchronously without any problems

Actual behaviour

When interacting with the NPC the conversation is cached but does not start

Steps to reproduce

This usually happens randomly a few minutes after starting the server. I haven't found any way to reproduce it

Error, Warning, Exception or Thread Dump

No response

Additional information

It gets stuck on Conversation#selectOption if conditions are evaluated asynchronously. The same thing happens when login out, where if Conversation#endConversation is run in another thread, it doesn't remove the player from its cache

Additionally, when the player disconnects again, the cached instance is no longer the same as the current one, causing it to no longer try to remove its listeners

https://youtu.be/G520uFf8hko

[Wolf2323]

What conversation IO do you use?

[Condordito]

menu

[Wolf2323]

As we are not able to reproduce this, and it is probably a bug caused by maybe an other plugin or so, i close this now. once we have a reproducable setup we can reopen this.

We also discussed this a bit in discord, and can continue there until we have found the setup to reproduce