-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay in minutes is not working #2564
Comments
Additionaly after working more with this awesome package I think I found a bug in the There seems to be going something wrong on the like statement when a "" is in the $class This doesnt work public function scopeMailableClass($query, $class)
{
$query->where('mailable_class', 'LIKE', "%Modules\EnergySubmission\Mail\IncompleteSubmissionMissingMeterSerialMailable%");
} This neither public function scopeMailableClass($query, $class)
{
$query->where('mailable_class', 'LIKE', "%\IncompleteSubmissionMissingMeterSerialMailable%");
} This works public function scopeMailableClass($query, $class)
{
$query->where('mailable_class', 'LIKE', "%IncompleteSubmissionMissingMeterSerialMailable%");
} |
Wip in this fork: https://github.com/zonneplan/laravel-mailator/commits/master |
Thanks @dstollie , any progress with that one? |
I Think that there is a bug where delay_minute is not working properly
In
AfterConstraint.php
The below code at the end diffs the hours between the delay_minutes. I think the diff should be done in minutes.
After working some more with this package I think I discovered an additional issue; In the
AfterConstraint
the condition should always be>=
instead of>
. When you have an delay of 1 hour you expected i to sent after 1 hour instead of > 1 hourr.48 AfterConstraint.php
Should be
The text was updated successfully, but these errors were encountered: