Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In After Constraint, minutes frequency not working. #2575

Open
encoderit-salman opened this issue Jun 6, 2023 · 0 comments · May be fixed by #2581
Open

In After Constraint, minutes frequency not working. #2575

encoderit-salman opened this issue Jun 6, 2023 · 0 comments · May be fixed by #2581

Comments

@encoderit-salman
Copy link

Please review

AfterConstraint.php

return $schedule->isOnce() ? $schedule->timestamp_target->diffInHours(now()->floorSeconds()) === $schedule->delay_minutes : $schedule->timestamp_target->diffInHours(now()->floorSeconds()) > $schedule->delay_minutes;

Should be like this

return $schedule->isOnce() ? $schedule->timestamp_target->diffInMinutes(now()) >= $schedule->delay_minutes && is_null($schedule->completed_at) : $schedule->timestamp_target->diffInMinutes(now()) > $schedule->delay_minutes;
on line 46 to 48

@badcristian badcristian linked a pull request Mar 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant