fix: calculate afterConstrain diff in minutes #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2575
this was used on line 47:
$schedule->timestamp_target->diffInMinutes(now()->floorSeconds()) >= $schedule->delay_minutes
instead of this:
$schedule->timestamp_target->diffInMinutes(now()->floorSeconds()) === $schedule->delay_minutes
because the second option will work only if mailator will be run every minute, which will probably not happen. So, for example, if the notification should be sent 10m after a target time and when the mailator is run we are more than 20m past it i think this should return true anyway.