Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for OP_CHECKSIGVERIFY #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for OP_CHECKSIGVERIFY #346

wants to merge 1 commit into from

Conversation

s2mr
Copy link

@s2mr s2mr commented Aug 13, 2018

close #281

@codecov-io
Copy link

Codecov Report

Merging #346 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   44.31%   44.48%   +0.16%     
==========================================
  Files         149      149              
  Lines        4206     4206              
==========================================
+ Hits         1864     1871       +7     
+ Misses       2342     2335       -7
Impacted Files Coverage Δ
BitcoinCashKit/Core/Crypto.swift 91.93% <0%> (+1.61%) ⬆️
...ore/Scripts/OP_CODE/Crypto/OP_CHECKSIGVERIFY.swift 100% <0%> (+75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b250466...92d6c81. Read the comment docs.

Copy link
Collaborator

@usatie usatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for BCH as well please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test OP_CHECKSIGVERIFY
3 participants