Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rqc can show "old values" #3208

Open
Macroz opened this issue Oct 30, 2023 · 0 comments
Open

rqc can show "old values" #3208

Macroz opened this issue Oct 30, 2023 · 0 comments
Labels
Technical Debt Improving internal product quality
Projects
Rems task board
Milestone
Internal cleanup

Comments

@Macroz
Copy link
Collaborator

Macroz commented Oct 30, 2023 •
edited

rqc can show "old values". It puts the request count at the start of request into MDC context. Therefore for the duration of the request processing the value remains the same. This can lead to strange looking log lines.

When we do structural logging and our own REMS logging wrappers, we can make the count to be dynamic.

See #3209
@Macroz Macroz created this issue from a note in Rems task board (Ideas) Oct 30, 2023
@Macroz Macroz added the Technical Debt Improving internal product quality label Oct 30, 2023
@Macroz Macroz added this to the Internal cleanup milestone Oct 30, 2023
@Macroz Macroz assigned Macroz and unassigned Macroz Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Technical Debt Improving internal product quality
Projects
REMS Task Board
Status: Ideas
Rems task board
Ideas
Milestone
Internal cleanup
Development

No branches or pull requests
1 participant
@Macroz