Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROLEAD terminates without error if certain options in config.set are set incorrectly. #12

Open
FelixUhle opened this issue Feb 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@FelixUhle
Copy link
Collaborator

Describe the bug
The release build of prolead does not throw an error if an incorrect number of expected_outputs or no_of_groups is given.
Instead, PROLEAD simply closes after "Read settings file..." is issued.

To Reproduce
Steps to reproduce the behavior:

  1. Select a working configuration.
  2. Manipulate it in a way that it contains either
% no_of_groups bug
no_of_groups % number of groups to conduct the test, e.g., fixed vs. fixed, fixed vs. random, etc.
2

64'h$$$$$$$$$$$$$$$$
%64'h$$$$$$$$$$$$$$$$

no_of_outputs
2

[31:0] rd_s0
[31:0] rd_s1

expected_output

32'h$$$$$$$$
32'h$$$$$$$$

, or

% expected_output bug
no_of_groups % number of groups to conduct the test, e.g., fixed vs. fixed, fixed vs. random, etc.
2

64'h$$$$$$$$$$$$$$$$
64'h$$$$$$$$$$$$$$$$

no_of_outputs
2

[31:0] rd_s0
[31:0] rd_s1

expected_output

32'h$$$$$$$$
%32'h$$$$$$$$
  1. Execute PROLEAD

Expected behavior
We expect a meaningful error message, which explains what the problem is.
In the first given case above the error message should contain information that two inputs must be given if no_of_outputs=2.
In the second case the error message should inform the user that two expected_outputs must be given if no_of_outputs=2.

Additional context
Since it is already planed to replace the current parser with a more robust one, using a standardized format (see #10),
we plan to address this bug by introducing the new parser.

@FelixUhle FelixUhle added the bug Something isn't working label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant