Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not read data from header chain #1769

Open
majecty opened this issue Sep 9, 2019 · 3 comments
Open

Do not read data from header chain #1769

majecty opened this issue Sep 9, 2019 · 3 comments

Comments

@majecty
Copy link
Contributor

majecty commented Sep 9, 2019

Header chain is not verified. Anyone could generate valid and high score header chain.
We should not read data from the header chain.

If we only use the Tendermint consensus, we can remove the header chain.

@kseo
Copy link
Member

kseo commented Sep 20, 2019

@majecty what was the original purpose of the header chain?

@majecty
Copy link
Contributor Author

majecty commented Sep 20, 2019

Verifying the chain before receiving the whole the chain. Since the best blockchain could be different from the best header chain, we should read the data only from the blockchain.

@junha1
Copy link
Contributor

junha1 commented Jan 16, 2020

Verifying header chain itself (aka header sync) can be reused in may places. For example the light client. So it would be better if we make separate module out of this after some fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants