Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package blacklist #139

Open
CRKatri opened this issue Apr 10, 2022 · 3 comments
Open

Package blacklist #139

CRKatri opened this issue Apr 10, 2022 · 3 comments

Comments

@CRKatri
Copy link

CRKatri commented Apr 10, 2022

It would be nice if it was possible to set a blacklist of packages that I would not like downloaded/extracted. This new option would accept a comma separated list of packages like -only_render_pkgs except be for packages to skip downloading for, instead of a whitelist of packages to render.

@stapelberg
Copy link
Contributor

What do you need this for? Either way, should be easy enough to implement. Do you want to send a PR?

@CRKatri
Copy link
Author

CRKatri commented Apr 10, 2022

Well I wanted to exclude certain packages with conflicting manpages, because there isn't a good way to programatically decide which is a better packages (ie flex vs flex-old). I have a bunch of jank patches to extract the manpages in a format to be parsed by mandoc's man.cgi which won't work well with conflicting manpages.

I was able to implement this by changing https://github.com/Debian/debiman/blob/master/cmd/debiman/getpackages.go#L91 to check a map of strings and bool and if it's in there:

entry = pkgEntry{}
continue

It seemed to work correctly based of some small testing

@stapelberg
Copy link
Contributor

stapelberg commented Apr 12, 2022

It would probably be a little cleaner to do the check next to line

if !containsMans[entry.binarypkg][arch] {

Do you want to send a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants