Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to official cryptography release #2817

Open
EchterAgo opened this issue Mar 22, 2024 · 1 comment
Open

Switch back to official cryptography release #2817

EchterAgo opened this issue Mar 22, 2024 · 1 comment
Labels
packaging Issues related to building/packaging and not the app itself. Reproducibility Issues related to deterministic build reproducibility

Comments

@EchterAgo
Copy link

We currently build the AppImage with a patched cryptography version that support reproducible builds. We should change this back to the official release as soon as the next version is released.
@cculianu cculianu added packaging Issues related to building/packaging and not the app itself. Reproducibility Issues related to deterministic build reproducibility labels Mar 22, 2024
EchterAgo added a commit to EchterAgo/Electron-Cash that referenced this issue May 8, 2024
@EchterAgo
build: Use official version 42.0.7 of cryptography
95e821d 
We added a patched version in 515021a
as a workaround for reproducible builds. Version 42.0.7 of cryptography
was released which includes our fix, so we switch back to that.

Closes Electron-Cash#2817
@EchterAgo
Copy link
Author

Just checked with the 42.0.7 release and it does not include the fix yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging Issues related to building/packaging and not the app itself. Reproducibility Issues related to deterministic build reproducibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cculianu @EchterAgo