-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scan for pom's in folder and subfolders and auto register #1
Comments
Hi cforce, It would be great to be able to provide a directory and autoregister every Ms in there. I will write it down as an improvement. Btw, If you have time and you want, you can implement it and, once done, create a pull request. It will e great ;) Enjoy your weekend! |
I really would if we have high demand, it will push if we do. Currently the feature is embedded in Spring Cloud Tools Boot Dashboard we already use on development side. Currently I won't have time but anyway I think your contribution will spread a lot more with that enhancement. |
Sure, I completely agree with you. Thanks for sharing your ideas! I will implement as soon as I can. |
Seems like a good feature to have. If not yet implemented, i can pick it up. |
Sure @siddhant0509. All yours. Make a fork and create a PR to be able to review it. Thanks for your effort!! |
Great .. big step forward ;) |
Hi, I'm planning to implement this feature. @ErnestOrt have any idea about how to start? |
Hi @mouradsm , This is a quite challenging task. If I where you, I would do the following:
As usual, adviceing is easier than coding, so take your time mate! We can do code reviews on each milestone so no worries for that, first make it work, second leave it clean! Good luck and thanks for you time! |
Not sure the status of this, however I also found an issue (somewhat related) where if I include the pom.xml file in the location of the "FileSystem" deployment, Trampoline will include the pom.xml and try to "cd" into it (e.g. ~/Documents/). Upon failure (since it can "cd" into a file, it will use the same "trampoline" location and start another trampoline instance. Would you prefer this handle here (in this issue) or enter it as a bug. Happy to contribute as well. Nice work here! |
Hi @albertoaflores, First of all, thanks for your time and feedback!! Probably, it would be better to handle it under other issue. Feel free to start a discussion about a solution and/or open PR! Have a nice Sunday!! 😉😉 |
With about 100 microservices you get a tough time to register them all manually ;)
Ms uses server port as configured in application.yml.
The text was updated successfully, but these errors were encountered: