Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkswitch should handle regular switches #4082

Open
AlekSi opened this issue Feb 15, 2024 · 3 comments · May be fixed by #4162
Open

checkswitch should handle regular switches #4082

AlekSi opened this issue Feb 15, 2024 · 3 comments · May be fixed by #4162
Assignees
@AlekSi @sbshah97
Labels
code/chore Code maintenance improvements community Issues and PRs assigned to community members good first issue Good issues for new external contributors

Comments

@AlekSi
Copy link
Member

AlekSi commented Feb 15, 2024

What should be done?

Currently, it handles only *ast.TypeSwitchStmt. It should also handle *ast.SwitchStmt to handle switches over bson.tag.

Where?

https://github.com/FerretDB/FerretDB/tree/main/tools/checkswitch

Definition of Done
@AlekSi AlekSi added good first issue Good issues for new external contributors code/chore Code maintenance improvements labels Feb 15, 2024
@kylediaz
Copy link

I'll give it a shot

@AlekSi AlekSi added the community Issues and PRs assigned to community members label Feb 21, 2024
@sbshah97
Copy link
Contributor

sbshah97 commented Mar 7, 2024

Hey @kylediaz is this something you are working on or is this something I can take up ?

@AlekSi AlekSi assigned sbshah97 and unassigned kylediaz Mar 7, 2024
@AlekSi
Copy link
Member Author

AlekSi commented Mar 7, 2024

@sbshah97 feel free to grab it

@sbshah97 sbshah97 linked a pull request Mar 9, 2024 that will close this issue
Open
7 tasks
@AlekSi AlekSi self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

@sbshah97 sbshah97

Labels
code/chore Code maintenance improvements community Issues and PRs assigned to community members good first issue Good issues for new external contributors
Projects
Current Engineering
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make checkswitch handle regular switches sbshah97/FerretDB
3 participants
@AlekSi @sbshah97 @kylediaz