Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helloOk field in isMaster op query #4132

Open
chilagrow opened this issue Feb 29, 2024 · 0 comments
Open

Add helloOk field in isMaster op query #4132

chilagrow opened this issue Feb 29, 2024 · 0 comments
Assignees
Labels
code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI

Comments

@chilagrow
Copy link
Contributor

What should be done?

helloOk Protocol Negotation is used to check that the server and the client both supports the hello command. If the client sends helloOk: true in isMaster and server responds back with helloOk: true as well, then both parties can start sending hello instead of isMaster on the connection.

This allows appropriate response for the client which supports hello.

see also #4111 (comment)

Where?

https://github.com/FerretDB/FerretDB/blob/main/internal/handler/cmd_query.go

Definition of Done

  • handler updated;
  • integration/compatibility tests added/updated;
  • spot refactorings done;
  • user documentation updated or an issue to create documentation created;
  • something else?
@chilagrow chilagrow added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI
Projects
None yet
Development

No branches or pull requests

2 participants