Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7tv Paints randomly vanish #194

Open
TheRealDadbeard opened this issue Jan 16, 2024 · 5 comments
Open

7tv Paints randomly vanish #194

TheRealDadbeard opened this issue Jan 16, 2024 · 5 comments

Comments

@TheRealDadbeard
Copy link

Since a couple of weeks now paints randomly vanish and come back after the user has written again, Badges are loaded wrong too.

@Lordmau5
Copy link
Collaborator

That's a 7TV issue. I've implemented the socket events according to spec.
(As in, if I get a "add cosmetics" event, I'll add it to a user. If I get a "remove cosmetics" event, I'll remove it from a user)

I'm not quite sure why it happens in their backend but if there's something I can do to maybe work around it I'd be happy to implement it.

cc @Melonify

@TheRealDadbeard
Copy link
Author

That's a 7TV issue. I've implemented the socket events according to spec. (As in, if I get a "add cosmetics" event, I'll add it to a user. If I get a "remove cosmetics" event, I'll remove it from a user)

I'm not quite sure why it happens in their backend but if there's something I can do to maybe work around it I'd be happy to implement it.

cc @Melonify

And they told me I was barking up the wrong tree because I was asking in their discord about that issue saying I am using FFZ.

Oh well maybe something can be done to fix it. Only using their addon seems to not be having that issue but it's just not that great.

@Lordmau5
Copy link
Collaborator

After looking at their code again the only difference I could see was that they are sending at most one presence message every 10 seconds, instead of on every chat message by the user.

I've implemented that as well in 1.4.18, maybe that'll help with the problem?

I'll leave the issue open for now, maybe Melonify can chime in with some extra thoughts (or perhaps he can have another look at the code) because this most definitely is an issue on their end

@TheRealDadbeard
Copy link
Author

After looking at their code again the only difference I could see was that they are sending at most one presence message every 10 seconds, instead of on every chat message by the user.

I've implemented that as well in 1.4.18, maybe that'll help with the problem?

I'll leave the issue open for now, maybe Melonify can chime in with some extra thoughts (or perhaps he can have another look at the code) because this most definitely is an issue on their end

Seems to be broken again. It was better before but now I very rarely get my paint shown.

@Lordmau5
Copy link
Collaborator

Lordmau5 commented Apr 9, 2024

7tv issue as per usual

Edit: Checked in with the 7TV devs, they didn't do any changes on their end so ultimately it could be a slow / wonky connection on the user-end when connecting to the socket (as in, it not connecting right away but delayed after a couple of seconds)

I've observed delayed paints myself but they'll show after some time (if they aren't showing instantly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants