Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - search from note list view doesn't always jump to first highlight when opening note #932

Open
clach04 opened this issue Nov 16, 2023 · 4 comments

Comments

@clach04
Copy link

clach04 commented Nov 16, 2023

This may be a combination bug report and enhancement request. Searching notes globally is a pain.

I think I've seen highlight and jump happen a few times but most of the time opening notes from search view requires opening up note search and re-entering in search term... for each note.

@vHanda
Copy link
Contributor

vHanda commented Nov 16, 2023

Would you mind recording a mini video to show what you mean?

@clach04
Copy link
Author

clach04 commented Nov 16, 2023

Would you mind recording a mini video to show what you mean?

Maybe? I've not done a recording before so need to so some home work. In the mean time steps below.

Steps

  1. create file (copy/paste from below file)
  2. in main list view hit search/magnifying glass (top right'ish of screen)
  3. search for line 049
  4. Click on the hit, no sign of the text that was searched for.

Repeat but for step 3, replace search term with line 030 - will see highlighted (as it fits on screen,... at least on my phone ;-))

test file

named issue_932_testcase.txt (no meta data)

    issue_932_testcase
    https://github.com/GitJournal/GitJournal/issues/932
    issue932 line 003
    issue932 line 004
    issue932 line 005
    issue932 line 006
    issue932 line 007
    issue932 line 008
    issue932 line 009
    issue932 line 010
    issue932 line 011
    issue932 line 012
    issue932 line 013
    issue932 line 014
    issue932 line 015
    issue932 line 016
    issue932 line 017
    issue932 line 018
    issue932 line 019
    issue932 line 020
    issue932 line 021
    issue932 line 022
    issue932 line 023
    issue932 line 024
    issue932 line 025
    issue932 line 026
    issue932 line 027
    issue932 line 028
    issue932 line 029
    issue932 line 030
    issue932 line 031
    issue932 line 032
    issue932 line 033
    issue932 line 034
    issue932 line 035
    issue932 line 036
    issue932 line 037
    issue932 line 038
    issue932 line 039
    issue932 line 040
    issue932 line 041
    issue932 line 042
    issue932 line 043
    issue932 line 044
    issue932 line 045
    issue932 line 046
    issue932 line 047
    issue932 line 048
    issue932 line 049

@clach04
Copy link
Author

clach04 commented Nov 16, 2023

https://osdn.net/projects/kumagusu/ handles this really well (sadly no longer on Google Play 😢 ). I have the code forked into https://github.com/clach04/kumagusu_mirror which I believe has the latest 1.21 code but I've not had chance to rebuild it yet (I'm not an Android developer). APK if you trust random APKs from strangers on the internet ;-p https://github.com/clach04/kumagusu_mirror/releases/tag/1.21

@clach04
Copy link
Author

clach04 commented Nov 18, 2023

Recording shows hits but then not showing the last hit (or a way to find it)
https://github.com/GitJournal/GitJournal/assets/424032/d6fc09f1-deac-492a-8784-0fad6e62db0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants