Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃馃搫 v1.87.0 deletes of files not honored, zombies files come back from the dead #962

Open
clach04 opened this issue Feb 5, 2024 · 10 comments

Comments

@clach04
Copy link

clach04 commented Feb 5, 2024

Steps:

  1. from a checkout (that GitJournal is not using)
  2. Delete file
  3. commit the delete
  4. push to sevver
  5. in git journal refresh/pull
  6. in other checkout pull - gi tlog shows GJ re-added the file 馃樋

Older version with c-git lib did not have this issue.

Deleting file inside GitJournal works (but a pain if want to delete a bunch of files/notes.

Deleting from git dir on phone, then syncing does NOT work.

@clach04 clach04 changed the title 馃馃搫 v1.87.0 deletes of files not honors zombies files come back from the dead 馃馃搫 v1.87.0 deletes of files not honored, zombies files come back from the dead Feb 5, 2024
@tschager
Copy link

I am having the same issue with v1.87.0+3768

@davidluhr
Copy link

davidluhr commented Mar 11, 2024

Having this issue as well. I had to uninstall the app because this was causing major issues for me. I spent a long time pruning and reorgranizing an extensive collection of notes, and GitJournal's sync re-added the notes in their original location. I had to hard reset the GitJournal commit and remove the app entirely to avoid this risk.

I hope there is a simple fix for this. Perhaps the change to dart-git is related to this?

The commit description for 80cbb05 mentions the following:

while my own dart-git's merging is quite bad in comparison to libgit2, it's the only way to move forward without libgit2

Is this issue caused by dart-git's merging?

@ptvirgo
Copy link

ptvirgo commented Apr 17, 2024

Probably goes without saying but if someone finds a workaround, please let us know.

@tschager
Copy link

The only workaround I know is to delete the app before the delete operations and re-install afterwards..

@davidluhr
Copy link

I've unfortunately had to uninstall the app to avoid the issue. I miss it; it was a valuable part of my personal knowledge management and without it I don't have a way to edit my notes without a computer.

I'm hoping there's a solution and will happily upgrade to a paid plan if this is resolved.

@clach04
Copy link
Author

clach04 commented Apr 18, 2024

The only workaround I know is to delete the app before the delete operations and re-install afterwards..

Untested but I'm guessing breaking the link to the git repo maybe another similar workaround without having to uninstall and then reinstall.

@clach04
Copy link
Author

clach04 commented Apr 18, 2024

I've unfortunately had to uninstall the app to avoid the issue. I miss it; it was a valuable part of my personal knowledge management and without it I don't have a way to edit my notes without a computer.

I'm hoping there's a solution and will happily upgrade to a paid plan if this is resolved.

MGit works great in this area, but you would then need to use a separate editor (like quick edit https://play.google.com/store/apps/details?id=com.rhmsoft.edit or https://billthefarmer.github.io/notes/) so working work flow but slightly less automated.

@vHanda
Copy link
Contributor

vHanda commented Apr 19, 2024

Sorry about this issue guys. I just tried to reproduce it, and the files are getting deleted on my end.

GitJournal/foam@a2df80a

I'm going to spend another 15-20 minutes now to try and reproduce this. If I can reproduce it, I'll happily fix it. I rarely delete notes since I mostly use GitJournal for journaling and not note taking, but I hate to see it so broken for all of you.

@vHanda
Copy link
Contributor

vHanda commented Apr 19, 2024

Nevermind. I managed to reproduce it. I understand what's going on. Let me try and fix it.

@davidluhr
Copy link

@vHanda Thank you so much! Excited to be able to use the app and again and I appreciate all your work to provide this for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants