3.8.2

[Davidy22]

What's Changed

• Fix system font only being applied to last tab by @Davidy22 in Fix system font only being applied to last tab #1954
• Use keycode for keybindings by @vantu5z in Use keycode for keybindings #1953
• Replace ｜ with non unicode dependent | by @Davidy22 in Replace ｜ with non unicode dependent | #1966
• Update news file by @Davidy22 in Update news file #1951
• Add pbr fallback by @Davidy22 in Add pbr fallback #1964
• Fix vte spawn_sync runtime check failed by @mlouielu in Fix vte spawn_sync runtime check failed #1974
• Add GUAKE_ENABLE_WAYLAND environment variable by @VitalyAnkh in Add GUAKE_ENABLE_WAYLAND environment variable #1975
• Add instructions for PPA install by @Davidy22 in Add instructions for PPA install #1961
• Switch default for hide tab bar if only one tab to disabled by @Davidy22 in Switch default for hide tab bar if only one tab to disabled #1983
• Changed default keybindig to toggle hide on lose focus. Fix Ctrl+F1 does two jobs in Keyboard Shortcuts Page #1719 by @jcfstabile in Changed default keybindig to toggle hide on lose focus. Fix #1719 #1988
• Fix module gi not found when make run by @jcfstabile in Fix module gi not found when make run  #1989
• Revert "Fix module gi not found when make run " by @mlouielu in Revert "Fix module gi not found when make run " #1992
• Drop pbr by @eli-schwartz in Drop pbr #1991
• Bump pipenv from 2021.5.29 to 2022.1.8 by @dependabot in Bump pipenv from 2021.5.29 to 2022.1.8 #2005
• Fix upload to pypi test by @Davidy22 in Fix upload to pypi test #2002
• Fix translation file inclusion by @Davidy22 in Fix translation file inclusion #2004
• feature: --is-visible option Add an --is-visible option #1926 by @rjeb in feature: --is-visible option #1926 #2008
• Reinstate double click to open tabs by @Davidy22 in Reinstate double click to open tabs #2010
• Fix deepsource complaints by @Davidy22 in Fix deepsource complaints #2009
• ci: enable upload to pypi by @Davidy22 in ci: enable upload to pypi #2007
• Generate release notes for 3.8.2 by @Davidy22 in Generate release notes for 3.8.2 #2012
• Update translation from Weblate by @gsemet in Update translation from Weblate #2013
• Revert "doc: update NEWS.rst" by @Davidy22 in Revert "doc: update NEWS.rst" #2014
• ci: no pipeline on pull_request by @gsemet in ci: no pipeline on pull_request #2016
• Revert "ci: no pipeline on pull_request" by @Davidy22 in Revert "ci: no pipeline on pull_request" #2018
• Fix arbitrary execution via dbus security flaw by @Davidy22 in Fix arbitrary execution via dbus security flaw #2017
• Eliminate redundant terminal spawning by @Davidy22 in Eliminate redundant terminal spawning #2020
• Generate release notes for 3.8.2 by @Davidy22 in Generate release notes for 3.8.2 #2024

New Contributors

• @VitalyAnkh made their first contribution in Add GUAKE_ENABLE_WAYLAND environment variable #1975
• @jcfstabile made their first contribution in Changed default keybindig to toggle hide on lose focus. Fix #1719 #1988
• @rjeb made their first contribution in feature: --is-visible option #1926 #2008

Full Changelog: 3.8.1...3.8.2

---

This discussion was created from the release 3.8.2.

[Darkle]

Will this release make it to pypi?
Thanks.

[gsemet]

Sûre within the day !

[Darkle]

It still seems to be 3.7.0 on pypi: https://pypi.org/project/guake/

[gsemet]

I have released 3.8.3 which basically replaces 3.8.2. I also have disabled merge commit because it seems to mess with how PBR computes version.

[Davidy22]

Still seems to be uploading weirdly, for now, since we clearly have valid wheels we can just manually upload the latest manually

[gsemet]

indeed, not fixed, because of setuptools_scm: #2037

[eli-schwartz]

The release process seems to be modifying the source code locally, causing git describe to report a "dirty" version.

setuptools_scm then computes the version with the dev node and timestamp, because it isn't a clean release. But in my PR to implement setuptools_scm I configured the timestamp to not be used, because it didn't match the previous style.

What this means: the release process is trying to release {tag}.dev0.dirty with a slightly confusing name of {tag}.dev0, which in retrospect may not have been the most optimal configuration setting to use.

The best solution here is to fix the release workflow to not report unstaged changes. Alternatively I could take a look at fine-tuning the setuptools_scm config so that it doesn't report on dirty changes.

[eli-schwartz]

... and we cross-posted. :)

[gsemet]

i like actually the way setuptools_scm works, but with guake we still have dirty files even during normal build. Ideally we would take the github tag information as source of truth (if GITHUB_REF_TYPE==tag, then take GITHUB_REF_NAME for the version string)