Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar stats don't update after another user uses a buffing abililty #14461

Open
CuriousMagpie opened this issue Jan 23, 2023 · 2 comments · May be fixed by #14920
Open

Avatar stats don't update after another user uses a buffing abililty #14461

CuriousMagpie opened this issue Jan 23, 2023 · 2 comments · May be fixed by #14920

Comments

@CuriousMagpie
Copy link
Member

Description

The web's party interface doesn't show people's updated health/exp/mana on mouseover, say after you've used a MP sharing ability (and hit sync), or been away for a while. Moreover, clicking on a person's portrait, or clicking on "view party", show the right amounts, but mousing over even after doing that still shows the old ones. It appears there's not really any way to update those values besides closing/reopening. Hitting Sync also doesn't affect it.

UUID: 6b4501bb-01d4-4887-b980-258218df5344
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36

@Pran-Ker
Copy link

Quick check, does this issue persist even after you cleared cache?
Once cache and cookies are cleared, the values should be updated on mouseover.

@ArbiterBibendi
Copy link

ArbiterBibendi commented Oct 5, 2023

Hey, I'd like to try and tackle this if that is ok.
This is potentially my first contribution ever, so if there is something I am doing wrong please don't hesitate to correct me.

I believe the problem was introduced in #14544, because the state is no longer being updated in the cast method of bulk spells.

My proposed change is by updating the state after the action user:castSpell is called in the castEnd() method in website\client\src\mixins\spells.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment