Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Setting Directory Relative directory should not point to System32 #507

Open
OnkelM opened this issue Oct 4, 2023 · 2 comments
Open

Comments

@OnkelM
Copy link

OnkelM commented Oct 4, 2023

Why do i call this a bug?
The term relative indicates to be relative to the parent, hence it should point to the path of the SystemTrayMenu.exe

The current situation also prevents usage in portable situations.

Also if the application cannot open/find the root folder and the popup asks to choose a directory, it should not repeat itself infinite if i click on the Cancel button.

  • OS: Windows 11
  • Version 1.3.5.0
@Hofknecht
Copy link
Owner

@OnkelM
do you mean this button?
image
this button only makes sense when STM it portable on usb stick and also the root folder is on the the same usb stick and then a relative folder makes sense, therefore we made this button.

if there is no valid path STM can not show any menu, so a valid path is a necessary settings to start the app

@OnkelM
Copy link
Author

OnkelM commented Oct 27, 2023

nevermind i found the issue, the relative path is taken correctly but the application retrieves also the startup folder for the MenuDataDirectoryState which can fail if the SystemTrayMenu.exe is started from another "current" directory.

e.g. running this in cmd "C:\temp> c:\programdata\systemtraymenu\1.3.5.0\systemtraymenu.exe" will result in the error "You have no access to the root directory of the app. Grant access to the directory or change the root directory."

but runnig it while in the correct folder e.g. ""C:\ProgramData\SystemTrayMenu\1.3.5.0> systemtraymenu.exe" will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants