Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Update RSS with post delition. #452

Open
Virviil opened this issue Oct 19, 2016 · 5 comments
Open

Update RSS with post delition. #452

Virviil opened this issue Oct 19, 2016 · 5 comments
Labels
Milestone

Comments

@Virviil
Copy link

Virviil commented Oct 19, 2016

I don't know if it should be done, but I think that if the post is deleted - the RSS feed should be also updated to remove link to this post

@jaredmorgs
Copy link
Contributor

I'd agree that this should happen.

Do you agree @anthonny ?

Might need to make RSS feed rebuild part of the relevant plugin.

@anthonny
Copy link
Member

Hi @Virviil,

I agree too, but it should already delete the post because the RSS feed is rebuild when a publish is done.
Did you notice this bug using the RSS feed through your website or by checking the content of the file stored on your repository?

I suppose that it is a cache problem but i will try to reproduce.

@Virviil
Copy link
Author

Virviil commented Oct 19, 2016

The track is something like this:

  • I've created blog post around midnight Utc
  • Deleted it somewhen near that, my a hour later
  • Checked RSS near noon UTC, feed had the post
  • Manualy removed rss.xml
  • Github responded 404 in minute or something like that

So I don't think that it's cache

The point is that if you have hooks to rebuild feed on deletion, or the hooks are only on createion.
I didn't watch source yet.

And of course I can watch direct times in commits, if you need it.

@anthonny
Copy link
Member

Ok, thanks

I think i've got it: https://github.com/Virviil/virviil.github.io/tree/126fd2d6a9d05dcec11b6f629708dee531da60a7

Pretty sure it's a bug when a user delete his last post

@jaredmorgs
Copy link
Contributor

@anthonny would this have been fixed as part of the 0.7.0 release? Should we get @Virviil to re-test after updating?

@jaredmorgs jaredmorgs added this to the Release 10 milestone Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants