Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command #4695

Closed
1 task done
lkurzyniec opened this issue Feb 19, 2024 · 10 comments · Fixed by #4982
Closed
1 task done

Update command #4695

lkurzyniec opened this issue Feb 19, 2024 · 10 comments · Fixed by #4982
Assignees
Labels
🚀 feat New feature

Comments

@lkurzyniec
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

What would you like to see changed/added?

If that's possible, It would be nice to have an update command. I could just type oh-my-posh update and magic would happen (I mean, the latest version would be installed). After all, restart of terminal and I have the newest version on my machine.

@marchello2000
Copy link

+1 this would be awesome

@JanDeDobbeleer
Copy link
Owner

@lkurzyniec this is a huge challenge depending on how you installed. For Windows, check. For macOS and Linux not so much.

@lkurzyniec
Copy link
Author

Yeah, I could imagine that it can be a huge challenge. That's why I have added "If that's possible" :)

@nopeless
Copy link
Contributor

ideally if you have installed a software using a package manager, the software should be managed and updated by the package manager. This would be outside of the scope of oh-my-posh

@JanDeDobbeleer
Copy link
Owner

@nopeless exactly. Unless you went for a manual install, in which case running the same install command will upgrade the binary and included themes.

For those of you who request this, how did you install oh-my-posh?

@lkurzyniec
Copy link
Author

I have installed by installer (windows, exe), but I have no problem to start using winget.

It's worth to consider to adjust install PS script (https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/website/static/install.ps1) to start using winget (or other package manager) as well.

@JanDeDobbeleer
Copy link
Owner

@lkurzyniec I don't mind seeing if we can add this for Windows only. Seems solvable.

@392781
Copy link

392781 commented Mar 20, 2024

ideally if you have installed a software using a package manager, the software should be managed and updated by the package manager. This would be outside of the scope of oh-my-posh

Except there is no unified package manager for Linux... Homebrew is sort of a bandaid fix for that and running curl every time to update kinda sucks. Granted, packaging for major distros is a headache on its own.

@JanDeDobbeleer
Copy link
Owner

@392781 running curl or update internally is kind of the same logic that will be executed tbh.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented May 31, 2024

OK, this is funny. Inno installer can't replace oh-my-posh when the installer is being invoked from oh-my-posh as that means oh-my-posh is running and has a lock on it 😆 Works on unix though....

EDIT: solved with a go routine to allow the installer to start and oh-my-posh to stop

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants