Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(document-store): enhancements to module for asset management #8518

Open
pujavs opened this issue May 15, 2024 · 1 comment
Open

feat(document-store): enhancements to module for asset management #8518

pujavs opened this issue May 15, 2024 · 1 comment
Assignees
@yurem @shekhar16
Labels
kind-feature Issue or PR is a new feature request
Milestone
1.1.3

Comments

@pujavs
Copy link
Contributor

pujavs commented May 15, 2024

image

As per above chat request

  • Part1: Enhancement here would be to remove the path requirement as discussed so that it follows a pre defined service location.- Thus remove jansFilePath field.
  • Part 2: All the jans services need to pull from persistence also following the same logic regarding the path requirement being predefined. I think this is a core service @yurem There cannot be any dependency on the filesystem to persist anything.
  • Suggestion from @syntrydy to replace jansModuleProperty field with new field called services. This also imply that the column is present on the db side"
  • Suggestion from @syntryd - There should be predefined list of service where assests can be copied to
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label May 15, 2024
@pujavs pujavs changed the title feat(document-store): enhancements to module for asset magament feat(document-store): enhancements to module for asset management May 15, 2024
@shekhar16
Copy link
Contributor

2ee1ee1

shekhar16 added a commit that referenced this issue May 28, 2024
@shekhar16
feat(document-store): add jansServices values in AssetMgtConf #8518
f24d6af 
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
@shekhar16 shekhar16 mentioned this issue May 28, 2024
Merged
@moabu moabu added this to the 1.1.3 milestone May 29, 2024
yurem pushed a commit that referenced this issue May 31, 2024
@shekhar16 @yurem
feat(document-store): add jansServices values in AssetMgtConf #8518
771ef6a 
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Signed-off-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
yuriyz pushed a commit that referenced this issue May 31, 2024
@shekhar16
feat(document-store): renamed jansModuleProperty->jansServices (#8599)
5c59189 
* feat(document-store): replace jansModuleProperty with jansServices#8518

Signed-off-by: shekhar16 shekharlaad1609@gmail.com

* feat(document-store): add jansServices values in AssetMgtConf #8518

Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>

---------

Signed-off-by: shekhar16 shekharlaad1609@gmail.com
Signed-off-by: shekhar16 <shekharlaad1609@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurem yurem

@shekhar16 shekhar16

Labels
kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
5 participants
@yurem @shekhar16 @pujavs @moabu @mo-auto