Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix All Creator Tokens discovery #6233

Open
bedeho opened this issue Apr 29, 2024 · 2 comments
Open

Fix All Creator Tokens discovery #6233

bedeho opened this issue Apr 29, 2024 · 2 comments
Assignees
Labels
idea Idea for a new feature pending-triage Requires triage before any work can begin

Comments

@bedeho
Copy link
Member

bedeho commented Apr 29, 2024

Problem

Currently it looks like this

Screenshot 2024-04-29 at 09 21 13

the problem is that

  1. by default its dominated with "dead" tokens with 0 vol and mcap, as most of the tokens fall in this category, and certainly most of the recent ones.
  2. it makes it very hard to discover any interesting tokens

Proposal

  • By default focus on high volume accounts
  • Allow controlling ordering of rows by toggling column
@bedeho bedeho added idea Idea for a new feature pending-triage Requires triage before any work can begin labels Apr 29, 2024
@bedeho bedeho changed the title Idea: Fix All Creator Tokens discovery Apr 29, 2024
@WRadoslaw
Copy link
Contributor

WRadoslaw commented Apr 29, 2024

It will require quite some work on both Atlas and Orion.

Atlas:

  • there is no support for header base sorting for table component (I don't expect it to be trivial)
  • mcap is a value calculated on the frontend, so there is no way to order it by it
  • total revenue is a value that is living on channel entity, so there is no way to order tokens by another entity property

Orion:

  • for mcap it would require some mapping changes, basically tracking the market cap as the supply and price changes, and then exposing it to the frontend as token property
  • for total revenue - this one is more tricky since there is no code-efficient way for a token to keep track of the channels' total revenue value. @zeeshanakram3 proposed one solution with using Views as a way to always have to most recent data without major work, but it introduces a performance overhead

@bedeho
Copy link
Member Author

bedeho commented Apr 29, 2024

Thanks for such a comprehensive answer.

there is no support for header base sorting for table component (I don't expect it to be trivial)

Why would this be difficult? What am I missing?

for mcap it would require some mapping changes

Yes, def. it should not be computed on front-end, and computing on backend is quite easy, we are proessing trades anyway, so with each trade the mcap is just recomputed, just 1-2 extra lines in that mapping.

for total revenue - this one is more tricky since there is no code-efficient way for a token to keep track of the channels' total revenue value.

Why would we not just add a new field that accumulates all channel account inflows, wich can come via member remarks with payment primarily, thats all we care about now really.


Seems most of the work is Orion here, are you able to do this Orion work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Idea for a new feature pending-triage Requires triage before any work can begin
Projects
None yet
Development

No branches or pull requests

3 participants