Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad loading state transition on feature carousel #6238

Open
bedeho opened this issue Apr 30, 2024 · 5 comments
Open

Bad loading state transition on feature carousel #6238

bedeho opened this issue Apr 30, 2024 · 5 comments
Assignees
Labels
idea Idea for a new feature pending-triage Requires triage before any work can begin

Comments

@bedeho
Copy link
Member

bedeho commented Apr 30, 2024

When going to market place, there is a nasty artefact when loading the carousel. It is visible between the grey loading state and when the content is actually rendered, and it looks like a sort of highlight border around the cards, gives a bad feeling like an error or something broke, tried to take screenshot, not sure I really captured. I'm on firefox.

Screenshot 2024-04-30 at 16 59 14
@bedeho bedeho added idea Idea for a new feature pending-triage Requires triage before any work can begin labels Apr 30, 2024
@WRadoslaw
Copy link
Contributor

Let's set a time box for debugging this. I tried to fix it for 30-60 mins before this issue was raised, not sure how much more we are willing to sacrifice

@bedeho
Copy link
Member Author

bedeho commented May 6, 2024

Were you able to reproduce it?

@WRadoslaw
Copy link
Contributor

Were you able to reproduce it?

Reproduce - yes, fix - not ;C

I assume you are talking about the black screen with a white border when loading skeleton disappears and the video is not yet shown.

@bedeho
Copy link
Member Author

bedeho commented May 7, 2024

yep. I don't think this is a bug though, at least that is not obvious, it may just be that this state does not look so good.

@WRadoslaw
Copy link
Contributor

I will give it an hour max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Idea for a new feature pending-triage Requires triage before any work can begin
Projects
None yet
Development

No branches or pull requests

2 participants