Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI checks #5109

Open
ignazio-bovo opened this issue Mar 20, 2024 · 4 comments
Open

Fix CI checks #5109

ignazio-bovo opened this issue Mar 20, 2024 · 4 comments
Assignees
@ignazio-bovo
Labels
network-integration-test End-to-end full network integration test

Comments

@ignazio-bovo
Copy link
Contributor

ignazio-bovo commented Mar 20, 2024 •
edited

TLDR

Fix all CI checks after the Luxor release

Background

  • Many runtime changes have been added to Luxor runtime but not to Luxor QN, disregarding the tests/network-tests checks as a consequence
  • We have chosen to forego fixing all the CI checks in the runtime PR adding the desired features, to avoid having complex PRs
  • We now need a (possibly unique) PR updating all the network test so that the CI checks are successful
@ignazio-bovo ignazio-bovo added network-integration-test End-to-end full network integration test luxor-network labels Mar 20, 2024
@ignazio-bovo ignazio-bovo self-assigned this Mar 20, 2024
@mnaamani
Copy link
Contributor

For the runtime upgrade tests, both the integration test and the cargo unit test we need to filter out the storage state which is huge and the memory is running out on the machine when the test is running.

@ignazio-bovo
Copy link
Contributor Author

  • Runtime upgrade integration test ➡️ It's the one using fork-off, right?
  • Runtime upgrade unit tests ➡️ is it the one with the try_runtime feature?
    @mnaamani

@mnaamani mnaamani mentioned this issue Apr 4, 2024
Merged
@ignazio-bovo
Copy link
Contributor Author

@kdembler
To sum it up: given that luxor has been released, have the CI checks been updated and fixed ?

@kdembler
Copy link
Member

kdembler commented Apr 17, 2024 •
edited

@ignazio-bovo Luxor upgrade is happening tomorrow, I don't think CI checks have been fixed

@ignazio-bovo ignazio-bovo changed the title Fix CI checks for Luxor Fix CI checks Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ignazio-bovo ignazio-bovo

Labels
network-integration-test End-to-end full network integration test
Projects
BWG work board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnaamani @kdembler @ignazio-bovo