Fix vote lock display, conditionally disable recovery, improve modal

[traumschule]

Hello! Today i want to draw attention to three more or less cosmetic bugs that can lead to confusion.

When a user chooses to recover a vote lock the transaction fails.

• The displayed vote is 2 years old.
• The recover button should be disabled due to a more recent vote lock.
• The displayed modal copy "Unstaking has been forbidden for the user (at least for now)" sounds more drastic than it has to.

Below the more recent vote by the same stake for a different candidate in the last election:

Solution

To fix the above i suggest the following changes:

• Make sure the correct (latest) vote is displayed under locks. edit: duplicate of My profile: "My accounts" - some accounts show old votes from 2-3 election cycles ago that have already been recovered #4668
• Ensure the Recover button is disabled if the vote was for a winner in the last election. Allow recovering in all other cases (which should work according to the fix applied 2 years ago).
• Change the modal copy to "The stake is currently locked due to a recent election.". It's possible that other cases may apply and should be mentioned as well but it's unlikely since @Ondrata mentioned in above issue that this specific error is only raised for failed can_unlock_vote_stake ([USERSNAP] Show why transaction failed. #2835 Display error code in the error modal #2621).

Tx details

For reference all displayed information

RECOVERABLE LOCKS:
Voting

LOCK DATE
30/12/2022, 05:42 PM WET

300,453 block


[Modal]
Oh no! Failure
Unstaking has been forbidden for the user (at least for now)

[Tx poopup]
Transaction failed
Error code: referendum.UnstakingForbidden

error.ts:1 Transaction error: Withdraw, TransactionFeePaid, ExtrinsicFailed
on network: wss://rpc.joystream.org:9944
in block: 0xb6f2b0410bca2271c0ed0f5bc08eb288e004d30562c13cfc5161190084500ed3
more details at: https://polkadot.js.org/apps/?rpc=wss://rpc.joystream.org:9944#/explorer/query/0xb6f2b0410bca2271c0ed0f5bc08eb288e004d30562c13cfc5161190084500ed3