-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Proposal: Amend Constitution #876
Comments
What kind of field should we create there? On the figma design there should be dropzone (https://www.figma.com/file/pgNl83wgAub186krVkdiuo/Proposals?node-id=265:19450). On the other hand, the api expects text there. |
@bedeho & @stepien4soft For now I'd propose a markdown input: |
The constitution is effectively a very large text document, hence, its very implausible that someone is going to be editing it directly in Pioneer. More likely, they would take the existing constitutional text, edit it using some other software, and then want to make a proposal out of this finished text, which likely would be a file. So what would be useful would indeed be to allow just a dropzone for a file, but additionally, what could be useful would be to show a Diff to the user before the proposal submission happens, so that they can be sure they are picking the correct file. This diff viewer should probably also just have an effort kind of state if the selected file is not a valid Markdown file, e.g. if they picked something random, like a video or mp3 or something. If doing these extra steps requires additional help from a designer, then please make issues describing this, and add this work to the backlog, we should not block completing some MVP version of this proposal in order to get all of this extra functionality I am describing here. Hope that helps. |
Closing this according to #4390 (comment) |
@figma
Handle proposal's specific parameters:
See notes in #806.
Without it the issue is a 2.
The text was updated successfully, but these errors were encountered: