Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proposal: Amend Constitution #876

Closed
1 task
jodator opened this issue Jun 21, 2021 · 4 comments
Closed
1 task

Add Proposal: Amend Constitution #876

jodator opened this issue Jun 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request post-mainnet scope:proposals The "Proposals" page and related features

Comments

@jodator
Copy link
Contributor

jodator commented Jun 21, 2021

@figma

Handle proposal's specific parameters:

  • New constitution upload field

See notes in #806.

⚠️ Diff in RTFs? How to fetch and display?

Without it the issue is a 2.

@jodator jodator added this to the Proposals milestone Jun 21, 2021
@jodator jodator added scope:proposals The "Proposals" page and related features enhancement New feature or request labels Jun 21, 2021
@jodator jodator added this to Product backlog in Pioneer Jun 22, 2021
@jodator jodator modified the milestones: Proposals, Before Release Jul 22, 2021
@jodator jodator removed this from Product backlog in Pioneer Jul 27, 2021
@jodator jodator mentioned this issue Nov 23, 2021
20 tasks
@stepien4soft stepien4soft added this to To do in Olympia via automation Dec 2, 2021
@stepien4soft
Copy link
Contributor

What kind of field should we create there? On the figma design there should be dropzone (https://www.figma.com/file/pgNl83wgAub186krVkdiuo/Proposals?node-id=265:19450). On the other hand, the api expects text there.
For now the easiest way to implement this proposal is set this field as a text input. Let me know what do you think

@jodator
Copy link
Contributor Author

jodator commented Dec 6, 2021

For now the easiest way to implement this proposal is set this field as a text input. Let me know what do you think

@bedeho & @stepien4soft For now I'd propose a markdown input:

@WRadoslaw WRadoslaw moved this from To do to Blocked in Olympia Dec 6, 2021
@bedeho
Copy link
Member

bedeho commented Dec 6, 2021

The constitution is effectively a very large text document, hence, its very implausible that someone is going to be editing it directly in Pioneer. More likely, they would take the existing constitutional text, edit it using some other software, and then want to make a proposal out of this finished text, which likely would be a file. So what would be useful would indeed be to allow just a dropzone for a file, but additionally, what could be useful would be to show a Diff to the user before the proposal submission happens, so that they can be sure they are picking the correct file. This diff viewer should probably also just have an effort kind of state if the selected file is not a valid Markdown file, e.g. if they picked something random, like a video or mp3 or something. If doing these extra steps requires additional help from a designer, then please make issues describing this, and add this work to the backlog, we should not block completing some MVP version of this proposal in order to get all of this extra functionality I am describing here.

Hope that helps.

@Qcza Qcza assigned dmtrjsg and unassigned stepien4soft and WRadoslaw Jan 10, 2022
@dmtrjsg dmtrjsg removed the olympia label Jan 24, 2022
@bedeho bedeho removed this from Blocked in Olympia Jan 24, 2022
@dmtrjsg dmtrjsg removed this from the Olympia milestone Apr 6, 2022
@traumschule
Copy link
Contributor

Closing this according to #4390 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request post-mainnet scope:proposals The "Proposals" page and related features
Projects
None yet
Development

No branches or pull requests

6 participants