-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karma is deprecated #8939
Comments
I thought we would migrate away from Karma sooner or later anyway — it's a very old project and a pretty stale one. Web Test Runner looks pretty nice. |
@Falke-Design as part of our migration to Web Test Runner we need all of our dependencies used during the testing process to be ESM compatible. Since you are maintaining |
@jonkoops done |
@Falke-Design Awesome thanks! Could you also publish a 2.0 for that package? |
Should be already there 🤔 |
Strange, it is not showing up on NPM. |
I forgot to publish ... 😄 I will do it at the evening (in 6h) |
I also had to refactor |
@jonkoops done |
Tried porting a small part of the tests to Web Test Runner to get a feel for it — looks like it works pretty well overall. Here's the commit: e9a3cf3 A few hiccups I've encountered:
I guess we could address both by setting the built Leaflet version as the entry point in the import maps rather than |
Yeah, basically only Chrome supports this at the moment, and it only supports the now defunct
Ah yes, I hadn't considered that. We'll have to find a way to get that working.
Yeah, ideally we'd be able to load it directly from source, but there are likely still benefits to having a bundled version. We'll have to evaluate this based on user demand I think. I think right now the most critical thing is that we want to move the test suite away from Karma, we can worry about details for the distribution later. We might also consider using Vitest, which has the advantage that we can rely on Vite being the bundler, of which my experience has been pretty good. It also has a built-in browser mode. @mourner perhaps you could raise the Web Test Runner code as a draft PR? We can see if we can do some collaboration to get it landed. |
Yeah, just wanted to put it out there as an option. I think Web Test Runner might make more sense for us now, also because it will allow us to keep the test suite pretty much unmodified otherwise. |
Alternatively we might also consider uvu, but it seems extremely minimal. |
@jonkoops love uvu, would be really awesome if we could get it to work with multiple browsers on CI and enough flexibility. The minimalistic approach fits the one from Leafet really well, and the new bloated frameworks are really tiring (very hard to debug and maintain). |
Yeah, totally agree with that assessment. Unfortunately it's a bit too minimal, since the docs reference browser support, but fail to actually provide details aside from a very bare-bones example. |
Karma has been deprecated today, so we'll likely have to migrate away from it at some point. We might want to consider Web Test Runner as the blog post from the Angular team suggests.
The text was updated successfully, but these errors were encountered: