Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAX_BIP32_PATH_STEPS to 10 #103

Open
bigspider opened this issue Jan 24, 2023 · 0 comments
Open

Increase MAX_BIP32_PATH_STEPS to 10 #103

bigspider opened this issue Jan 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@bigspider
Copy link
Collaborator

In order to better support use cases with longer derivation paths, it would be better to support longer BIP-32 paths for derivations and pubkey export.

To avoid memory problems on Nano S, we have to ascertain that increasing the constant does not lead to an increase in memory usage in critical paths, and in the global variables for UI (affected by MAX_SERIALIZED_BIP32_PATH_LENGTH).
Moreover, double check that the various UX flows are still reasonable when the paths are longer.

@bigspider bigspider added this to the 2.2.0 milestone Jan 25, 2023
@bigspider bigspider added the enhancement New feature or request label Mar 27, 2023
@bigspider bigspider removed this from the 2.2.0 milestone Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant