Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow up to 5 data pushes in OP_RETURN outputs #259

Merged
merged 5 commits into from May 13, 2024
Merged

Allow up to 5 data pushes in OP_RETURN outputs #259

merged 5 commits into from May 13, 2024

Conversation

bigspider
Copy link
Collaborator

@bigspider bigspider commented May 6, 2024 •
edited

Closes: #245

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.89%. Comparing base (e6b45ad) to head (5fe7f05).

Files Patch % Lines
src/common/script.c 93.75% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #259      +/-   ##
===========================================
+ Coverage    84.85%   84.89%   +0.04%     
===========================================
  Files           17       17              
  Lines         2192     2205      +13     
===========================================
+ Hits          1860     1872      +12     
- Misses         332      333       +1
Flag Coverage Δ
unittests 84.89% <93.75%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tdejoigny-ledger
tdejoigny-ledger previously approved these changes May 13, 2024
View reviewed changes
Copy link

@tdejoigny-ledger tdejoigny-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to add some defines for relevant constants. It will be easier to understand

src/common/script.c Outdated Show resolved Hide resolved
src/common/script.c Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 13, 2024 •
edited

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bigspider bigspider merged commit 74190fb into develop May 13, 2024
115 checks passed
@bigspider bigspider deleted the opreturn branch May 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Allow multiple data pushes in OP_RETURN output
3 participants
@bigspider @codecov-commenter @tdejoigny-ledger