Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly test text content in ragger tests #251

Open
bigspider opened this issue Apr 4, 2024 · 0 comments
Open

Explicitly test text content in ragger tests #251

bigspider opened this issue Apr 4, 2024 · 0 comments
Labels

Comments

@bigspider
Copy link
Collaborator

bigspider commented Apr 4, 2024

The test test_register_wallet_tr_with_nums_keypath added in #250 explicitly needs to check that the key @0 in the wallet policy is correctly identified as dummy. The test currently relies on the screenshot.

It would be great to also test explicitly the text events that appeared on screen, in order to prevent an incorrect screenshot to be inadvertently attached to the test. For example, in the above test, one could check that the string Key @0, dummy did appear on-screen at some point.

Another test where such checks make sense: test_sign_psbt_singlesig_large_amount.

Once this is addressed in ragger, it's worth going through the ragger tests to add the relevant screen checks based on the text events.

@bigspider bigspider added the tests label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant