Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Class constructor Transport cannot be invoked without 'new' #5503

Closed
bucko13 opened this issue Nov 17, 2023 · 16 comments
Closed

[Bug]: Class constructor Transport cannot be invoked without 'new' #5503

bucko13 opened this issue Nov 17, 2023 · 16 comments
Labels
bug Something isn't working libraries Impacts the Libraries Stale triage In need of triage

Comments

@bucko13
Copy link

bucko13 commented Nov 17, 2023

Impacted Library name

@ledgerhq/hw-transport-webusb, @ledgerhq/hw-transport

Impacted Library version

6.28.8

Describe the bug

When using this library in another library, we were running into an error whenever we needed to instantiate a transport. It wasn't clear what was causing the issue as there didn't seem to be a change in the webusb library between when it was working and when it wasn't. It turns out that if we locked hw-transport to 6.28.1 then the ledger device communication would work again.

This is the PR that fixed it in our library unchained-wallets: unchained-capital/unchained-wallets#137

Expected behavior

Should be able to instantiate a new web usb transport

Additional context

No response

@bucko13 bucko13 added bug Something isn't working libraries Impacts the Libraries triage In need of triage labels Nov 17, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@bucko13
Copy link
Author

bucko13 commented Dec 18, 2023

I’d like to keep this issue open and curious if there has been an opportunity to address it. Currently the only way we are able to keep libraries building without error is pinning an upstream dependency in any environment it’s used.

@github-actions github-actions bot removed the Stale label Dec 19, 2023
@bucko13
Copy link
Author

bucko13 commented Jan 3, 2024

Any update on this? We're still seeing this issue and it's very disruptive to active development.

Copy link

github-actions bot commented Feb 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Feb 3, 2024
@bucko13
Copy link
Author

bucko13 commented Feb 4, 2024

I got a notification that this is going stale but it’s still an active problem for us in production environments. Pinning upstream dependencies is a patch for now but makes it very hard to maintain.

@github-actions github-actions bot removed the Stale label Feb 4, 2024
Copy link

github-actions bot commented Mar 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@bucko13
Copy link
Author

bucko13 commented Mar 5, 2024

Still a very active issue as far as I’m aware. Would love an update on this so we can update our ledger dependencies.

@github-actions github-actions bot removed the Stale label Mar 6, 2024
@sirtimid
Copy link

sirtimid commented Mar 6, 2024

We had to override the dependency to 6.28.1 so this is still an issue.

Copy link

github-actions bot commented Apr 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@github-actions github-actions bot added the Stale label Apr 6, 2024
@bucko13
Copy link
Author

bucko13 commented Apr 9, 2024

Still active. Awaiting response so we can upgrade libraries.

@live-github-bot
Copy link
Contributor

@bucko13 you are not part of the organization, please contact a maintainer if you need to run this command.

3 similar comments
@live-github-bot
Copy link
Contributor

@bucko13 you are not part of the organization, please contact a maintainer if you need to run this command.

@live-github-bot
Copy link
Contributor

@bucko13 you are not part of the organization, please contact a maintainer if you need to run this command.

@live-github-bot
Copy link
Contributor

@bucko13 you are not part of the organization, please contact a maintainer if you need to run this command.

@github-actions github-actions bot removed the Stale label Apr 10, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it.

@bucko13
Copy link
Author

bucko13 commented May 17, 2024

Has this issue actually been resolved? We still have to keep our ledger dependencies pinned to avoid breaking builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libraries Impacts the Libraries Stale triage In need of triage
Projects
None yet
Development

No branches or pull requests

2 participants