Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Flatpak install says "nightly" when I install latest stable #570

Open
1 task done
markwmuller opened this issue Jan 15, 2024 · 5 comments
Open
1 task done
Assignees
Labels
bug Something isn't working ci confirmed good first issue Good for newcomers

Comments

@markwmuller
Copy link

What happened?

Installing Butterfly via flatpak (https://flathub.org/apps/dev.linwood.butterfly) gives me version 2.0.0, but the banner at the top says "Butterfly Nightly". I'm guessing there's a mixup somewhere.

image

image

I'm using Ubuntu 22.04.

Version

2.0.0

Platform

Linux

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@CodeDoctorDE
Copy link
Member

Thanks for reporting. The bug shouldn't be too critical, with the nightly version you can try out the collaboration feature

@CodeDoctorDE
Copy link
Member

Fixed in 2.0.1

@CodeDoctorDE
Copy link
Member

Reopened because it didn't fix the problem

@CodeDoctorDE CodeDoctorDE reopened this Jan 15, 2024
@derkrasseleo
Copy link

Can confirm, just installed butterfly flatpak and also got the nightly

@CodeDoctorDE
Copy link
Member

Yeah, the problem is:
The check for nightly is wrong:

if: ${{ github.ref != 'refs/tags/stable' && (github.event_name != 'release' || github.event.prerelease) }}

The github.event_name is "push" and we don't get the information if the running job is inside a prerelease or not

@CodeDoctorDE CodeDoctorDE added the good first issue Good for newcomers label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci confirmed good first issue Good for newcomers
Projects
Status: 🚧 In Progress
Development

No branches or pull requests

3 participants