Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: performance issue on large single page #667

Open
1 task done
Luciogi opened this issue Apr 19, 2024 · 10 comments
Open
1 task done

[Bug]: performance issue on large single page #667

Luciogi opened this issue Apr 19, 2024 · 10 comments
Assignees
Labels
bug Something isn't working confirmed

Comments

@Luciogi
Copy link
Contributor

Luciogi commented Apr 19, 2024

What happened?

A bug happened!
when moving around on canvas

Platform Tested:
WPA(firefox)
Android

File: https://github.com/LinwoodDev/Butterfly/files/15015668/butterfly.bfly.zip

Version

2.1.0-rc.0

Platform

Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Luciogi Luciogi added the bug Something isn't working label Apr 19, 2024
@CodeDoctorDE
Copy link
Member

thanks for reporting, i tested it myself and on firefox it is very buggy, on windows it seems to handle it (maybe because the pc is better than a phone)

@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 19, 2024

Umm After comparing Chromium and firefox (on Laptop with power mode on performance) both give nearly same performance when moving around on canvas. From my previous observations I think so my laptop was running on power saving mode

I think that, tools like path eraser and eraser are causing performance issue

@CodeDoctorDE
Copy link
Member

Okay thanks. I just wanted to be sure I could reproduce this behavior.
I will look at it and try to fix it

@Luciogi
Copy link
Contributor Author

Luciogi commented May 7, 2024

path eraser tool when delete an element whole visible area is canvas is rerendered.
I am also not sure if it refresh objects what are not visible on screen

bdf04323-5fac-49fe-aa2b-3007df3760ed.mp4

@CodeDoctorDE
Copy link
Member

Which version do you use currently?

@Luciogi
Copy link
Contributor Author

Luciogi commented May 7, 2024

2.1.0-rc.3
just installed latest apk from gitbub actions

@CodeDoctorDE
Copy link
Member

Okay thanks, i will check it

@CodeDoctorDE
Copy link
Member

fixed in 2.1.1-rc.1

@Luciogi
Copy link
Contributor Author

Luciogi commented May 20, 2024

32e6522d-66d6-4d44-8b4a-aa428eccbfa1.mp4
  • the easer path pointer is also too slow
  • Erasing path, misses paths , it could be due to slowness of pointer

@CodeDoctorDE
Copy link
Member

thanks for testing, I will try to improve this a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
Status: 📕 Todo
Development

No branches or pull requests

2 participants