Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten quotes does not set off error detector.... #3344

Open
BKeyport opened this issue Jan 10, 2024 · 2 comments · Fixed by MagicMirrorOrg/MagicMirror-Documentation#225

Comments

@BKeyport
Copy link
Contributor

In relation to pull 225 request in docs, I noticed I forgot the quotes when setting up the new configuration/introduction. In testing, this created an error that the actual mirror catches and shows the error screen, but the configuration checker does not pick up on - I did not check if it picks it up without the enviroment variable.

bkey1970@officemirror:~/MagicMirror $ export MM_CONFIG_FILE=config/config2.js
npm run config:check

> magicmirror@2.26.0 config:check
> node js/check_config.js

[10.01.2024 15:09.58.458] [INFO]  Checking file...  /home/bkey1970/MagicMirror/config/config2.js
[10.01.2024 15:09.58.629] [INFO]  Your configuration file doesn't contain syntax errors :)
@BKeyport
Copy link
Contributor Author

This shouldn't have been transferred. There's a bug in the config:check routine that passes invalid lines like was in the old version of the config documentation. It'll pass with

module: clock,
position: fullscreen_above,

which is not correct.

@rejas
Copy link
Collaborator

rejas commented Jan 11, 2024

Ups, my bad. Shouldnt do stuff directly after waking up...

@rejas rejas reopened this Jan 11, 2024
@rejas rejas transferred this issue from MagicMirrorOrg/MagicMirror-Documentation Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants