Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calendar] Wrong values on broadcasted fullday events with RRULE #3422

Open
eouia opened this issue Apr 9, 2024 · 0 comments
Open

[calendar] Wrong values on broadcasted fullday events with RRULE #3422

eouia opened this issue Apr 9, 2024 · 0 comments

Comments

@eouia
Copy link
Contributor

eouia commented Apr 9, 2024

Platform: All

Node Version: v20.8.0

MagicMirror² Version: 2.27

Description: A repeated(BY RRULE) full-day event is shown as normal on screen, but it has the wrong value internally, so it delivers the wrong value on broadcasting as a notification.

Steps to Reproduce:

  1. Sample ics URL : https://calendar.google.com/calendar/ical/41bfece74ae469910f6414f6f0e6d7348bd1cd5eb442d3f415ade4388ea453f9%40group.calendar.google.com/public/basic.ics

  2. It has two events, one for single fullday event, and the other for repeated fullday event.
    image

  3. Those are displayed as a normal on the MM screen because Fullday event doesn't show the startTime.

image
  1. But inside of the logic, Repeated events have wrong parsed startTime.(Or at least it has wrong TZ information)
    To check this;
    image

modules/default/calendar/calendar.js line 417

This shows;
image
Repeated events don't start at 00:00. It starts at 02:00 I think it is due to Europe/Berlin Timezone (GMT+2)

Usually, it doesn't matter because full-day events do not show the exact time. But when the events are broadcasted, they deliver the wrong time value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant