New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 2881 extended calendar to receive notifications from other modules, but code in wrong place #3443

Open

sdetweil opened this issue May 8, 2024 · 0 comments

Collaborator

sdetweil commented May 8, 2024 •

edited

the pr 2881 (august 22)

added this code

	socketNotificationReceived (notification, payload) {

		if (notification === "FETCH_CALENDAR") {  
			this.sendSocketNotification(notification, { url: payload.url, id: this.identifier });
		}

BUT the module CANNOT receive SOCKET notifications except from our helper, which NEVER sends this

instead is should have been added to a NEW function . responsible for incoming notifications from OTHER modules

     notificationReceived (notification, payload, sender) {

		if (notification === "FETCH_CALENDAR") {  
			this.sendSocketNotification(notification, { url: payload.url, id: this.identifier });
		}
      },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment