Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all the OnDeserialized methods from the codebase #3895

Closed
rockfordlhotka opened this issue Apr 30, 2024 · 2 comments · Fixed by #3955
Closed

Remove all the OnDeserialized methods from the codebase #3895

rockfordlhotka opened this issue Apr 30, 2024 · 2 comments · Fixed by #3955
Assignees
@luizfbicalho
Labels
kind/technical debt

Comments

@rockfordlhotka
Copy link
Member

CSLA no longer supports BinaryFormatter, and Microsoft is removing support for BinaryFormatter as of .NET 9.

There are still some instances of OnDeserialized methods in the codebase that (I believe) are now entirely obsolete, and they should be removed.
@luizfbicalho luizfbicalho mentioned this issue May 19, 2024
Merged
@luizfbicalho
Copy link
Contributor

Shoudn't this be closed by now?

@rockfordlhotka
Copy link
Member Author

@luizfbicalho my guess is that you forgot to put "fixed #xxxx" or "closed #xxxx" in the Text of the PR summary. Those key-phrases are what tell GitHub to automatically close an issue when the PR is merged.

@rockfordlhotka rockfordlhotka linked a pull request Jun 12, 2024 that will close this issue
Feature/remove on deserialized #3955
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizfbicalho luizfbicalho

Labels
kind/technical debt
Projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/remove on deserialized luizfbicalho/csla
2 participants
@rockfordlhotka @luizfbicalho