Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Metrics do not show the ui_customization property #24578

Closed
pnarayanaswamy opened this issue May 17, 2024 · 0 comments · Fixed by #24579
Closed

[Bug] Metrics do not show the ui_customization property #24578

pnarayanaswamy opened this issue May 17, 2024 · 0 comments · Fixed by #24579
Assignees
Labels
confirmation-redesign INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team

Comments

@pnarayanaswamy
Copy link
Contributor

No description provided.

@pnarayanaswamy pnarayanaswamy self-assigned this May 17, 2024
@pnarayanaswamy pnarayanaswamy added confirmation-redesign team-confirmations Push issues to confirmations team labels May 17, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label May 17, 2024
pnarayanaswamy added a commit that referenced this issue May 20, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Fixes the bug where the ui_customization property does not show up in
the metrics event.
Also fixed the mapping such that the ui_customization property shows up
for the eth_signTypedData as well.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24579?quickstart=1)

## **Related issues**

Fixes:
[#24578](#24578)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmation-redesign INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants